simon-git: putty (master): Simon Tatham
Commits to Tartarus CVS repository.
tartarus-commits at lists.tartarus.org
Wed May 6 20:53:58 BST 2015
TL;DR:
5e2443f Fix SSH-1 RSA key handling in Pageant.
Repository: git://git.tartarus.org/simon/putty.git
On the web: http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer: Simon Tatham <anakin at pobox.com>
Date: 2015-05-06 20:53:58
commit 5e2443ff1f07cb8cd7e6dd7d8cb044283c788478
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=5e2443ff1f07cb8cd7e6dd7d8cb044283c788478;hp=bc4066e454f38358f17860e3d4244f63b930f994
Author: Simon Tatham <anakin at pobox.com>
Date: Wed May 6 20:49:07 2015 +0100
Fix SSH-1 RSA key handling in Pageant.
The auxiliary values (the two primes and the inverse of one mod the
other) were being read into the key structure wrongly, causing
crt_modpow() in sshrsa.c to give the wrong answers where straight
modpow would not have.
This must have been broken ever since I implemented the RSA CRT
optimisation in 2011. And nobody has noticed, which is a good sign for
the phasing out of SSH-1 :-) I only spotted it myself because I was
testing all the Pageant message types in the course of implementing
the new logging.
pageant.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
More information about the tartarus-commits
mailing list