simon-git: putty (master): Simon Tatham

Fri May 15 12:58:24 BST 2015

TL;DR:
  b5fd596 Unix Pageant: fix further double-frees.
  fb4fbe1 Remove an entire unused function in Windows PuTTYgen.
  89da2dd Giant const-correctness patch of doom!

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2015-05-15 12:58:24

commit b5fd5969f4593917ccd07b34c06f0968931b695f
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=b5fd5969f4593917ccd07b34c06f0968931b695f;hp=a8c4e67ff9ebdced0a4fb393f934b22cb5aae02f
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri May 15 11:02:33 2015 +0100

    Unix Pageant: fix further double-frees.

    No need to sfree(err) before going to the cleanup code, because the
    whole point of shared cleanup code is that that will do it for us.

 unix/uxpgnt.c |    2 --
 1 file changed, 2 deletions(-)

commit fb4fbe11588d3e53be99909f57dd179d1105aaf5
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=fb4fbe11588d3e53be99909f57dd179d1105aaf5;hp=b5fd5969f4593917ccd07b34c06f0968931b695f
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri May 15 12:27:15 2015 +0100

    Remove an entire unused function in Windows PuTTYgen.

    When I did the public-key output revamp, I completely failed to notice
    I'd orphaned this function :-) Clean it up.

 windows/winpgen.c |   47 -----------------------------------------------
 1 file changed, 47 deletions(-)

commit 89da2ddf564a93414ee9ab2df3f053608094e417
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=89da2ddf564a93414ee9ab2df3f053608094e417;hp=fb4fbe11588d3e53be99909f57dd179d1105aaf5
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri May 15 11:15:42 2015 +0100

    Giant const-correctness patch of doom!

    Having found a lot of unfixed constness issues in recent development,
    I thought perhaps it was time to get proactive, so I compiled the
    whole codebase with -Wwrite-strings. That turned up a huge load of
    const problems, which I've fixed in this commit: the Unix build now
    goes cleanly through with -Wwrite-strings, and the Windows build is as
    close as I could get it (there are some lingering issues due to
    occasional Windows API functions like AcquireCredentialsHandle not
    having the right constness).

    Notable fallout beyond the purely mechanical changing of types:
     - the stuff saved by cmdline_save_param() is now explicitly
       dupstr()ed, and freed in cmdline_run_saved.
     - I couldn't make both string arguments to cmdline_process_param()
       const, because it intentionally writes to one of them in the case
       where it's the argument to -pw (in the vain hope of being at least
       slightly friendly to 'ps'), so elsewhere I had to temporarily
       dupstr() something for the sake of passing it to that function
     - I had to invent a silly parallel version of const_cmp() so I could
       pass const string literals in to lookup functions.
     - stripslashes() in pscp.c and psftp.c has the annoying strchr nature

 cmdgen.c           |    4 +-
 cmdline.c          |   27 +++++++-----
 conf.c             |   42 +++++++++++++++++--
 config.c           |   20 +++++----
 dialog.c           |   69 +++++++++++++++---------------
 dialog.h           |   60 +++++++++++++-------------
 import.c           |   21 ++++++----
 ldisc.c            |    4 +-
 ldiscucs.c         |    4 +-
 logging.c          |    2 +-
 macosx/osxctrls.m  |    2 +-
 macosx/osxdlg.m    |    2 +-
 macosx/osxmain.m   |   10 ++---
 macosx/osxwin.m    |    2 +-
 misc.c             |    4 +-
 network.h          |   13 +++---
 proxy.c            |    8 ++--
 proxy.h            |    2 +-
 pscp.c             |  119 +++++++++++++++++++++++++++++-----------------------
 psftp.c            |   34 ++++++++-------
 psftp.h            |   26 ++++++------
 putty.h            |   55 +++++++++++++-----------
 raw.c              |    6 +--
 rlogin.c           |    4 +-
 settings.c         |   28 +++++++------
 sftp.c             |   33 ++++++++-------
 sftp.h             |   20 +++++----
 ssh.c              |  118 ++++++++++++++++++++++++++++-----------------------
 ssh.h              |   13 +++---
 sshbn.c            |    2 +-
 sshpubk.c          |    4 +-
 telnet.c           |   10 ++---
 terminal.c         |    9 ++--
 unix/gtkask.c      |    2 +-
 unix/gtkdlg.c      |   19 +++++----
 unix/gtkfont.c     |    2 +-
 unix/gtkwin.c      |   14 +++----
 unix/unix.h        |   11 ++---
 unix/uxcons.c      |    3 +-
 unix/uxmisc.c      |    2 +-
 unix/uxnet.c       |    3 +-
 unix/uxpgnt.c      |   10 ++---
 unix/uxplink.c     |   12 +++---
 unix/uxproxy.c     |    2 +-
 unix/uxpterm.c     |    2 +-
 unix/uxpty.c       |    6 +--
 unix/uxputty.c     |   13 ++++--
 unix/uxser.c       |    6 +--
 unix/uxsftp.c      |   24 +++++------
 unix/uxucs.c       |    2 +-
 windows/wincons.c  |    3 +-
 windows/winctrls.c |    2 +-
 windows/window.c   |   14 +++----
 windows/wingss.c   |    2 +-
 windows/winmisc.c  |    2 +-
 windows/winnet.c   |    8 ++--
 windows/winpgen.c  |    6 +--
 windows/winpgnt.c  |    8 ++--
 windows/winplink.c |   12 +++---
 windows/winproxy.c |    2 +-
 windows/winser.c   |    4 +-
 windows/winsftp.c  |   24 +++++------
 windows/winucs.c   |    2 +-
 windows/winutils.c |    2 +-
 x11fwd.c           |    8 ++--
 65 files changed, 559 insertions(+), 450 deletions(-)