simon-git: putty (master): Simon Tatham

[Commits to Tartarus CVS repository.]

TL;DR:
  64d2837 Windows PuTTYgen: fix mis-setting of radio buttons.
  8dab2c2 Remove pointless NULL checks in the ECC code.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2015-05-15 13:53:59

commit 64d283702bbf0bde117fec5306d7f5cccfe75570
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=64d283702bbf0bde117fec5306d7f5cccfe75570;hp=89da2ddf564a93414ee9ab2df3f053608094e417
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri May 15 13:01:33 2015 +0100

    Windows PuTTYgen: fix mis-setting of radio buttons.
    
    The menu options and radio buttons for key type were not consistently
    setting each other when selected: in particular, selecting from the
    menu did not cause the ED25519 radio button to be either set or unset
    when that would have been appropriate.
    
    Looks as if I failed to catch in code review the fact that we should
    have _one_ call to each of CheckRadioButton and CheckMenuRadioItem,
    and they should both have the right 'first' and 'last' parameters

 windows/winpgen.c |   11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

commit 8dab2c24404b6f14ffb9472799d7621077a73bd6
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=8dab2c24404b6f14ffb9472799d7621077a73bd6;hp=64d283702bbf0bde117fec5306d7f5cccfe75570
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri May 15 13:27:15 2015 +0100

    Remove pointless NULL checks in the ECC code.
    
    snew(), and most of the bignum functions, are deliberately written to
    fail an assertion and terminate the program rather than return NULL,
    so there's no point carefully checking their every return value for
    NULL. This removes a huge amount of pointless error-checking code, and
    makes the elliptic curve arithmetic almost legible in places :-)
    
    I've kept error checks after modinv(), because that can return NULL if
    asked to invert zero. bigsub() can also fail in principle, because our
    bignums are non-negative only, but in the couple of cases where it's
    used there's a preceding compare that should prevent it, so I've just
    added assertions.

 sshbn.c  |   12 +-
 sshecc.c |  836 ++------------------------------------------------------------
 2 files changed, 28 insertions(+), 820 deletions(-)