simon-git: putty (master): Simon Tatham

Sat Apr 2 08:30:03 BST 2016

TL;DR:
  b4202c9 Fix a potential time-wraparound issue in pinger.c.
  b0b5d5f Extend ACL-restriction to all Windows tools.
  57477cb Warn about short RSA/DSA keys in PuTTYgen.
  8c0104c MSI installer: turn the desktop icon off by default.
  1620aef MSI installer: offer to display the README file after install.
  43f1aa0 Provide a separate post-install README for MSI.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2016-04-02 08:30:03

commit b4202c917a1e59dba2790463995959a2c2da745a
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=b4202c917a1e59dba2790463995959a2c2da745a;hp=46051027fbd16badfa72947a4763750c7e560a92
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Apr 1 13:27:03 2016 +0100

    Fix a potential time-wraparound issue in pinger.c.

    A compiler warning drew my attention to the fact that 'next' in
    pinger_schedule() was an int, not the unsigned long it should have
    been. And looking at the code that handles it, it was also taking no
    care with integer wraparound when checking whether an existing
    scheduled ping should be moved forward.

    So now I do something a bit more robust, by remembering what time it
    _was_ when we set pinger->next, and checking if the new time value
    falls in the interval between those two times.

 pinger.c |    8 +++++---
 putty.h  |    1 +
 timing.c |   11 +++++++++++
 3 files changed, 17 insertions(+), 3 deletions(-)

commit b0b5d5fbe63e982d6a230269a2e2a823e2586512
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=b0b5d5fbe63e982d6a230269a2e2a823e2586512;hp=b4202c917a1e59dba2790463995959a2c2da745a
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Apr 2 08:00:07 2016 +0100

    Extend ACL-restriction to all Windows tools.

    Protecting our processes from outside interference need not be limited
    to just PuTTY: there's no reason why the other SSH-speaking tools
    shouldn't have the same treatment (PSFTP, PSCP, Plink), and PuTTYgen
    and Pageant which handle private key material.

 Recipe             |    2 +-
 pscp.c             |    2 ++
 psftp.c            |    2 ++
 psftp.h            |    7 +++++++
 unix/uxsftp.c      |    2 ++
 windows/winpgen.c  |   18 ++++++++++++++++++
 windows/winpgnt.c  |   17 +++++++++++++++++
 windows/winplink.c |   17 +++++++++++++++++
 windows/winsftp.c  |   19 +++++++++++++++++++
 9 files changed, 85 insertions(+), 1 deletion(-)

commit 57477cb7caa7d48b93ab4c3bf3e4db5468dcb3ed
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=57477cb7caa7d48b93ab4c3bf3e4db5468dcb3ed;hp=b0b5d5fbe63e982d6a230269a2e2a823e2586512
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Apr 2 08:00:37 2016 +0100

    Warn about short RSA/DSA keys in PuTTYgen.

    It's only a warning; Windows PuTTYgen puts it up as a message box, and
    will still generate the key if you click yes, and Unix PuTTYgen just
    prints the warning and gets on with generation anyway. But it might
    help encourage people to move away from 1024-bit keys, if they're
    still using them.

 cmdgen.c          |    9 ++++++++-
 windows/winpgen.c |   14 +++++++++++++-
 2 files changed, 21 insertions(+), 2 deletions(-)

commit 8c0104ca0a188a2e039a2f6676e8b455ab148a1a
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=8c0104ca0a188a2e039a2f6676e8b455ab148a1a;hp=57477cb7caa7d48b93ab4c3bf3e4db5468dcb3ed
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Apr 2 08:00:17 2016 +0100

    MSI installer: turn the desktop icon off by default.

    I rushed out the MSI in too much of a hurry to sort out this kind of
    thing, but now we've got leisure to reconsider, I think it's better
    behaviour not to clutter everyone's desktops unless specifically asked
    to.

 windows/installer.wxs |   21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

commit 1620aef7c6ca54754111469a47645b26e049387e
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=1620aef7c6ca54754111469a47645b26e049387e;hp=8c0104ca0a188a2e039a2f6676e8b455ab148a1a
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Apr 2 08:00:25 2016 +0100

    MSI installer: offer to display the README file after install.

    This is a thing that the Inno Setup installer did, and that I didn't
    get round to replicating when I rushed out the initial MSI in a hurry.

    I've checked that this doesn't prevent unattended installation by
    administrators: running 'msiexec /q /i putty-whatever.msi' as
    administrator still installs silently after this change, without
    popping up the README unexpectedly on anyone's desktop as a side
    effect.

    (I _think_ - but I'm still a long way from an MSI expert - that that's
    because /q turns off the whole UI part of the MSI system, and the
    loading of README is actually triggered by the transition away from
    the final UI dialog box, which we now never visit in the first place.)

 Buildscr              |    2 +-
 windows/installer.wxs |   13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

commit 43f1aa01cd03eb8ab24cd61846fd4ef3ded883ba
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=43f1aa01cd03eb8ab24cd61846fd4ef3ded883ba;hp=1620aef7c6ca54754111469a47645b26e049387e
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Apr 2 08:22:12 2016 +0100

    Provide a separate post-install README for MSI.

    The old README.txt instructed you to manually update PATH if you
    wanted to run pscp from a command prompt. But the MSI installer can do
    that automatically, so the wording needs tweaks. And now that we're
    actually launching README (at least optionally) from the installer UI,
    it's more important to not make it look silly.

 windows/README-msi.txt |   45 +++++++++++++++++++++++++++++++++++++++++++++
 windows/installer.wxs  |    2 +-
 2 files changed, 46 insertions(+), 1 deletion(-)