simon-git: putty (master): Simon Tatham

Commits to Tartarus CVS repository. tartarus-commits at lists.tartarus.org
Sat Apr 2 14:25:15 BST 2016


TL;DR:
  8730ed5 Windows: compile with /D_CRT_SECURE_NO_WARNINGS.
  00960d8 Windows: condition setprocessacl() on lack of -DNO_SECURITY.
  83746d7 64-bit cleanness: use INT_PTR/UINT_PTR where appropriate.
  a5d7a6c 64-bit cleanness: fix integer types in winsftp.c.
  ef7a821 64-bit cleanness: fix a couple of format strings in winjump.c.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2016-04-02 14:25:15

commit 8730ed52976712ec9e0cd98afc997d6ad88f0adf
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=8730ed52976712ec9e0cd98afc997d6ad88f0adf;hp=16dfefcbdedb00354860adb32034ac0f3791833c
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Apr 2 09:21:55 2016 +0100

    Windows: compile with /D_CRT_SECURE_NO_WARNINGS.
    
    With all due respect to Microsoft, a cross-platform program simply
    cannot switch to using MS's assorted 'secure' versions of standard C
    functions if it wants to continue compiling on platforms other than
    Windows. So I might as well squash the warnings, so that any other
    more interesting compiler warnings can avoid being swamped in the
    mess.

 mkfiles.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 00960d8695e35faf6176f452fa09b5fef7b3d623
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=00960d8695e35faf6176f452fa09b5fef7b3d623;hp=8730ed52976712ec9e0cd98afc997d6ad88f0adf
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Apr 2 13:48:20 2016 +0100

    Windows: condition setprocessacl() on lack of -DNO_SECURITY.
    
    We also have the special-purpose -DUNPROTECT to disable just the ACL
    changes, but if you want to compile without any Windows security API
    support at all (e.g. experimentally building against winelib) then
    it's easier not to have to specify both defines separately.

 windows/window.c   |    2 +-
 windows/winpgen.c  |    2 +-
 windows/winpgnt.c  |    2 +-
 windows/winplink.c |    2 +-
 windows/winsftp.c  |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

commit 83746d7236e3109b1c5009262cf2b232583ffbba
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=83746d7236e3109b1c5009262cf2b232583ffbba;hp=00960d8695e35faf6176f452fa09b5fef7b3d623
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Apr 2 14:10:27 2016 +0100

    64-bit cleanness: use INT_PTR/UINT_PTR where appropriate.
    
    These integer types are correct for the id/handle parameter to
    AppendMenu / InsertMenu / DeleteMenu, and also for the return type of
    dialog box procedures.

 windows/windlg.c |   20 ++++++++++----------
 windows/window.c |    9 +++++----
 2 files changed, 15 insertions(+), 14 deletions(-)

commit a5d7a6c10285540371e84b495131a0ee938776e4
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=a5d7a6c10285540371e84b495131a0ee938776e4;hp=83746d7236e3109b1c5009262cf2b232583ffbba
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Apr 2 14:11:18 2016 +0100

    64-bit cleanness: fix integer types in winsftp.c.
    
    We were calling Windows file-handling API functions GetFilesize and
    SetFilePointer, each of which returns two halves of a large integer by
    writing the high half through a pointer, with pointers to the wrong
    integer types. Now we're always passing the exact type defined in the
    API, and converting after the fact to our own uint64 type, so this
    should avoid any risk of wrong-sized pointers.

 windows/winsftp.c |   27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

commit ef7a821bb19e657179cad5a383f3991c39a1c527
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=ef7a821bb19e657179cad5a383f3991c39a1c527;hp=a5d7a6c10285540371e84b495131a0ee938776e4
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Apr 2 14:12:12 2016 +0100

    64-bit cleanness: fix a couple of format strings in winjump.c.
    
    strcspn() returns a size_t, which is not safe to pass as the parameter
    in a printf argument list corresponding to a "*" field width specifier
    in the format string, because the latter should be int, which may not
    be the same size as size_t.

 windows/winjump.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list