simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Fri Dec 8 19:37:28 GMT 2017


TL;DR:
  2a2153f Fix assertion failure that prevents pterm starting up.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2017-12-08 19:37:28

commit 2a2153f4ced735bb75c87776c6b062b9b68679b4
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=2a2153f4ced735bb75c87776c6b062b9b68679b4;hp=b9a25510b0c31468a649660966b093e46b7e9533
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Dec 8 19:34:35 2017 +0000

    Fix assertion failure that prevents pterm starting up.
    
    When testing the previous commit, I went to great lengths to check all
    the tricky corner cases of the detailed command-line argument handling
    in Plink and PuTTY, on Windows and Unix. And did I also double-check
    that I had not completely broken the very simplest possible invocation
    of pterm? I did not.
    
    The call to cmdline_host_ok() in gtkmain.c was failing an assertion in
    pterm, because that function only expects to have been called by a
    program that has the TOOLTYPE_HOST_ARG flag set - if that flag isn't
    set, the program is expected to come up with its own answer to the
    question (because I wasn't sure what the right fallback answer would
    be). And I forgot to conditionalise the call between PuTTY and pterm.

 unix/gtkmain.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)



More information about the tartarus-commits mailing list