simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  c05fdb7 A small pile of Windows compiler-warning fixes.
  f26654f Stop front ends remembering the data of their last paste.
  9bff559 Move declaration of write_aclip into winstuff.h.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2017-12-10 09:28:05

commit c05fdb7d617149ac1da82c9760ed9d601dfd324f
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=c05fdb7d617149ac1da82c9760ed9d601dfd324f;hp=2a2153f4ced735bb75c87776c6b062b9b68679b4
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Dec 10 09:19:15 2017 +0000

    A small pile of Windows compiler-warning fixes.
    
    These include an unused variable left over from the command-line
    refactoring; an explicit referencing of the module handle for
    sspicli.dll which we really do deliberately load and then don't
    (directly) use; a missing pointer-type cast in the Windows handle
    socket code; and two 32/64 bit integer size mismatches in the types of
    functions I was importing from system API DLLs.
    
    The last of those are a bit worrying, and suggest to me that after
    going to all that trouble to add type-checking of those runtime
    imports in commit 49fb598b0, I might have only checked the resulting
    compiler output in a 32-bit build and not a 64-bit one. Oops!

 mkfiles.pl         | 3 ++-
 windows/winctrls.c | 2 +-
 windows/wingss.c   | 2 +-
 windows/winhelp.c  | 2 +-
 windows/winhsock.c | 2 +-
 windows/winmisc.c  | 1 +
 windows/winnet.c   | 4 ++--
 windows/winplink.c | 1 -
 8 files changed, 9 insertions(+), 8 deletions(-)

commit f26654f618cbfd99ff4c72b843db2f5fda5daa51
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=f26654f618cbfd99ff4c72b843db2f5fda5daa51;hp=c05fdb7d617149ac1da82c9760ed9d601dfd324f
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Dec 9 08:41:03 2017 +0000

    Stop front ends remembering the data of their last paste.
    
    Previously, both the Unix and Windows front ends would respond to a
    paste action by retrieving data from the system clipboard, converting
    it appropriately, _storing_ it in a persistent dynamic data block
    inside the front end, and then calling term_do_paste(term), which in
    turn would call back to the front end via get_clip() to retrieve the
    current contents of that stored data block.
    
    But, as far as I can tell, this was a completely pointless mechanism,
    because after a data block was written into this storage area, it
    would be immediately used for exactly one paste, and then never
    accessed again until the next paste action caused it to be freed and
    replaced with a new chunk of pasted data.
    
    So why on earth was it stored persistently at all, and why that
    callback mechanism from frontend to terminal back to frontend to
    retrieve it for the actual paste action? I have no idea. This change
    removes the entire system and replaces it with the completely obvious
    alternative: the character-set-converted version of paste data is
    allocated in a _local_ variable in the frontend paste functions,
    passed directly to term_do_paste which now takes (buffer,length)
    parameters, and freed immediately afterwards. get_clip() is gone.

 fuzzterm.c       |   1 -
 putty.h          |   3 +-
 terminal.c       | 102 +++++++++++++++++++++++++++----------------------------
 unix/gtkwin.c    |  38 +++++++--------------
 windows/window.c |  29 +++++-----------
 5 files changed, 72 insertions(+), 101 deletions(-)

commit 9bff5595a279f2882768323e482287286ec44998
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=9bff5595a279f2882768323e482287286ec44998;hp=f26654f618cbfd99ff4c72b843db2f5fda5daa51
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Dec 9 11:57:34 2017 +0000

    Move declaration of write_aclip into winstuff.h.
    
    It's actually a function specific to the Windows front end, and has
    been all along - but I've only just noticed that no other front end
    either uses it or defines it.

 putty.h            | 1 -
 windows/winstuff.h | 7 +++++++
 2 files changed, 7 insertions(+), 1 deletion(-)