simon-git: puzzles (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Tue Nov 6 18:40:22 GMT 2018


TL;DR:
  baed0e3 Fix a misuse of errno.
  3189fb4 Fix an inaccurate comment.

Repository:     https://git.tartarus.org/simon/puzzles.git
On the web:     https://git.tartarus.org/?p=simon/puzzles.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-11-06 18:40:22

commit baed0e3eec513aa148afaea950b43a4f8b8d2734
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=baed0e3eec513aa148afaea950b43a4f8b8d2734;hp=f281644b0be91917b7f9f43d7496140173d7ed2e
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Nov 6 18:33:21 2018 +0000

    Fix a misuse of errno.
    
    In menu_save_event, we checked ctx.error to see if an errno value had
    been left in it by the savefile_write callback, but if so, then we
    were passing the _current_ value of errno to strerror() in place of
    the saved value in ctx.error.
    
    This may well have been benign, but I spotted it in an eyeball review
    just now and thought I'd better fix it before it bit anyone.

 gtk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 3189fb484dcfe4efe42b2b30e529389db9dd0d00
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=3189fb484dcfe4efe42b2b30e529389db9dd0d00;hp=baed0e3eec513aa148afaea950b43a4f8b8d2734
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Nov 6 18:34:47 2018 +0000

    Fix an inaccurate comment.
    
    latin_solver_diff_set takes a boolean input parameter to indicate
    whether the 'Extreme'-level variant of set elimination is permitted.
    But it's commented in the header file as having a boolean _output_
    parameter which it sets if it _ended up_ using that variant. Probably
    the latter was how it worked in an early draft, and I changed my mind
    later without changing the comment.

 latin.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list