simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  1074a9be Stop BPPs from handling EOF before reading all data.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-11-28 20:27:06

commit 1074a9be4ce66ce4ca05d6698e563c42c62b5f10
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=1074a9be4ce66ce4ca05d6698e563c42c62b5f10;hp=dfe88e792a7f22492af4bcfe871bb89c4377a903
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Nov 28 20:16:41 2018 +0000

    Stop BPPs from handling EOF before reading all data.
    
    The BPP_READ macros in all four BPP implementations (including
    sshverstring) had the same bug: if EOF had been seen on the network
    input but there was _also_ enough data in the input queue to satisfy
    the current request, they would jump straight to complaining about the
    EOF rather than processing the available data first.
    
    I spotted this while trying to pipe in test data from a disk file, but
    it could easily also lead to us failing to handle the final message in
    the connection, e.g. losing the error message sent by the remote in a
    DISCONNECT message.

 ssh1bpp.c      | 15 ++++++++-------
 ssh2bpp-bare.c | 15 ++++++++-------
 ssh2bpp.c      | 15 ++++++++-------
 sshverstring.c | 15 ++++++++-------
 4 files changed, 32 insertions(+), 28 deletions(-)