simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Wed Oct 3 21:15:17 BST 2018


TL;DR:
  bf61af19 ssh2 conn: don't set mainchan_eof_sent when we didn't.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-10-03 21:15:17

commit bf61af1919f22775a0a3e272893a26499feacf23
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=bf61af1919f22775a0a3e272893a26499feacf23;hp=72a8c8c471131c76633ab3f252a38d78b7a46388
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Oct 3 20:55:01 2018 +0100

    ssh2 conn: don't set mainchan_eof_sent when we didn't.
    
    In mainchan_send_eof, which is the Channel method that gets called
    when EOF has been received from the SSH server and is now being passed
    on to the local endpoint, we decide whether or not to respond to the
    server-side EOF with a client-side EOF based on application
    preference. But I was doing the followup admin _outside_ that if
    statement, so if the server sent EOF and we _didn't_ want to send EOF
    in response, we still set the flag that said we'd sent it, and stopped
    reading from standard input. Result: if you use 'plink -nc' to talk to
    a remote network socket, and the server sends EOF first, Plink will
    never send EOF in the other direction, because it'll stop reading from
    standard input and never actually see the EOF that needs to be sent.

 ssh2connection.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list