simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Thu Oct 4 19:18:52 BST 2018


TL;DR:
  96ec2c25 Get rid of lots of implicit pointer types.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-10-04 19:18:52

commit 96ec2c2500b82c6a354e3472decad75bba660174
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=96ec2c2500b82c6a354e3472decad75bba660174;hp=bf61af1919f22775a0a3e272893a26499feacf23
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Oct 4 19:10:23 2018 +0100

    Get rid of lots of implicit pointer types.
    
    All the main backend structures - Ssh, Telnet, Pty, Serial etc - now
    describe structure types themselves rather than pointers to them. The
    same goes for the codebase-wide trait types Socket and Plug, and the
    supporting types SockAddr and Pinger.
    
    All those things that were typedefed as pointers are older types; the
    newer ones have the explicit * at the point of use, because that's
    what I now seem to be preferring. But whichever one of those is
    better, inconsistently using a mixture of the two styles is worse, so
    let's make everything consistent.
    
    A few types are still implicitly pointers, such as Bignum and some of
    the GSSAPI types; generally this is either because they have to be
    void *, or because they're typedefed differently on different
    platforms and aren't always pointers at all. Can't be helped. But I've
    got rid of the main ones, at least.

 be_misc.c                 |   4 +-
 contrib/cygtermd/main.c   |   2 +-
 contrib/cygtermd/telnet.c |  32 +++++++-------
 contrib/cygtermd/telnet.h |  12 +++---
 defs.h                    |  14 ++----
 errsock.c                 |  14 +++---
 network.h                 |  98 ++++++++++++++++++++---------------------
 noshare.c                 |   2 +-
 nullplug.c                |  10 ++---
 pageant.c                 |  18 ++++----
 pageant.h                 |   4 +-
 pinger.c                  |  16 +++----
 portfwd.c                 |  24 +++++------
 pproxy.c                  |   8 ++--
 proxy.c                   |  50 ++++++++++-----------
 proxy.h                   |   8 ++--
 putty.h                   |   8 ++--
 raw.c                     |  47 ++++++++++----------
 rlogin.c                  |  51 +++++++++++-----------
 ssh.c                     | 106 ++++++++++++++++++++++-----------------------
 ssh.h                     |  32 +++++++-------
 ssh1connection.c          |   4 +-
 ssh2connection.c          |   4 +-
 sshbpp.h                  |   2 +-
 sshppl.h                  |   6 +--
 sshshare.c                |  24 +++++------
 telnet.c                  |  75 ++++++++++++++++----------------
 unix/unix.h               |   2 +-
 unix/uxnet.c              | 104 ++++++++++++++++++++++----------------------
 unix/uxpgnt.c             |  18 ++++----
 unix/uxproxy.c            |  28 ++++++------
 unix/uxpty.c              |  74 +++++++++++++++----------------
 unix/uxser.c              |  43 +++++++++---------
 unix/uxshare.c            |   8 ++--
 windows/winhsock.c        |  26 +++++------
 windows/winnet.c          | 108 +++++++++++++++++++++++-----------------------
 windows/winnpc.c          |   8 ++--
 windows/winnps.c          |  24 +++++------
 windows/winproxy.c        |  18 ++++----
 windows/winser.c          |  33 +++++++-------
 windows/winshare.c        |   8 ++--
 x11fwd.c                  |  14 +++---
 42 files changed, 595 insertions(+), 596 deletions(-)



More information about the tartarus-commits mailing list