TL;DR:
69b216c1 Windows open_settings_r: return NULL for a nonexistent session.
55123b10 load_settings, do_defaults: return a boolean success flag.
d147f764 Plink: fix mishandling of launchable Default Settings.
e3e43150 Don't ask again about weak crypto primitives on rekey.
Repository: https://git.tartarus.org/simon/putty.git
On the web: https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer: Simon Tatham <anakin at pobox.com>
Date: 2019-02-27 21:14:10
commit 69b216c1166e08349c59803fbe35853fe29d735a
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=69b216c1166e08349c59803fbe35853fe29d735a;hp=1db5001260ee2e745e2863e2eba59cd307f126a5
Author: Simon Tatham <anakin at pobox.com>
Date: Wed Feb 27 20:29:13 2019 +0000
Windows open_settings_r: return NULL for a nonexistent session.
Previously, we returned a valid settings_r containing a null HKEY.
That didn't actually cause trouble (I think all the registry API
functions must have spotted the null HKEY and returned a clean error
code instead of crashing), but it means the caller can't tell if the
session really existed or not. Now we return NULL in that situation,
and close_settings_r avoids crashing if we pass the NULL to it later.
windows/winstore.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
commit 55123b105d5caf1e53cc36eac9f623ef17529d07
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=55123b105d5caf1e53cc36eac9f623ef17529d07;hp=69b216c1166e08349c59803fbe35853fe29d735a
Author: Simon Tatham <anakin at pobox.com>
Date: Wed Feb 27 20:30:47 2019 +0000
load_settings, do_defaults: return a boolean success flag.
Now the caller of one of those functions can tell whether the session
it loaded actually existed at all, or whether it was made up by
settings.c.
putty.h | 8 ++++++--
settings.c | 11 +++++++----
2 files changed, 13 insertions(+), 6 deletions(-)
commit d147f764eaca36b7a97180718793124d89e6fa9e
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=d147f764eaca36b7a97180718793124d89e6fa9e;hp=55123b105d5caf1e53cc36eac9f623ef17529d07
Author: Simon Tatham <anakin at pobox.com>
Date: Wed Feb 27 20:31:48 2019 +0000
Plink: fix mishandling of launchable Default Settings.
Plink's hostname argument can refer to a saved session instead of a
hostname. We test this by trying to load it as a session, and seeing
if the resulting Conf is launchable. But if Default Settings itself is
launchable (e.g. if it has the protocol set to Serial) then that can
happen even if there is no saved session with that name - in which
case we'll _never_ fall back to treating the argument as a host name.
Fixed by also checking the new success flag returned from do_defaults.
cmdline.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
commit e3e4315033a07c828608034d69feb83b6cda182a
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=e3e4315033a07c828608034d69feb83b6cda182a;hp=d147f764eaca36b7a97180718793124d89e6fa9e
Author: Simon Tatham <anakin at pobox.com>
Date: Wed Feb 27 20:54:35 2019 +0000
Don't ask again about weak crypto primitives on rekey.
If the user clicks 'ok' to a prompt such as 'should we carry on even
though the server only supports diffie-hellman-stage-whisper-sha0',
then we've done our duty to warn them about weak crypto, and shouldn't
nag them with the same confirmation prompt again and again in
subsequent rekeys. So now we keep a tree234 of all the algorithms the
user has consented to, so as to ask about each one at most once.
ssh2transport.c | 55 +++++++++++++++++++++++++++++++++++++++++++------------
ssh2transport.h | 8 ++++++++
2 files changed, 51 insertions(+), 12 deletions(-)