simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Thu Feb 28 08:53:34 GMT 2019


TL;DR:
  d07d7d66 Replace more ad-hoc growing char buffers with strbuf.
  3e881a42 Fix a few memory leaks.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-02-28 08:53:34

commit d07d7d66f662b670a94c58e68a083f512e57e7a8
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=d07d7d66f662b670a94c58e68a083f512e57e7a8;hp=e3e4315033a07c828608034d69feb83b6cda182a
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Feb 11 06:58:07 2019 +0000

    Replace more ad-hoc growing char buffers with strbuf.
    
    I've fixed a handful of these where I found them in passing, but when
    I went systematically looking, there were a lot more that I hadn't
    found!
    
    A particular highlight of this collection is the code that formats
    Windows clipboard data in RTF, which was absolutely crying out for
    strbuf_catf, and now it's got it.

 Recipe             |  2 +-
 cmdline.c          | 28 +++++++-----------
 import.c           | 62 +++++++++++----------------------------
 logging.c          | 18 ++++--------
 pscp.c             | 50 +++++++++++++++----------------
 sshpubk.c          | 50 ++++++++++---------------------
 sshverstring.c     | 40 ++++++++++---------------
 sshzlib.c          | 51 +++++++++++++++-----------------
 telnet.c           | 27 +++++++----------
 unix/uxplink.c     | 33 +++++++--------------
 unix/uxstore.c     | 29 +++++++++---------
 windows/window.c   | 86 ++++++++++++++++++++++++------------------------------
 windows/winplink.c | 33 +++++++--------------
 13 files changed, 196 insertions(+), 313 deletions(-)

commit 3e881a4248e241155710a4f978f8e7a0f39df44d
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=3e881a4248e241155710a4f978f8e7a0f39df44d;hp=d07d7d66f662b670a94c58e68a083f512e57e7a8
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Feb 28 06:19:31 2019 +0000

    Fix a few memory leaks.
    
    Mostly noticed in passing while using Address / Leak Sanitiser to
    check over the previous commit. One highlight here is freeing of the
    previous iqmp value in rsa_verify, which was actually a potentially
    sensitive leak, introduced in the mp_int rewrite (commit 25b034ee3).

 cmdgen.c      | 3 +++
 settings.c    | 1 +
 ssh2transhk.c | 1 +
 sshprime.c    | 1 +
 sshrsa.c      | 1 +
 5 files changed, 7 insertions(+)



More information about the tartarus-commits mailing list