simon-git: putty (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sun Sep 12 10:23:47 BST 2021


TL;DR:
  80f5105d sshproxy: keep addr and free it on close.
  c06c9c73 Fill in missing implementation of pty_sendbuffer.
  82177956 Divide seat_set_trust_status into query and update.
  c3366435 Separate backend_send from backend_sendbuffer.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2021-09-12 10:23:47

commit 80f5105dad377522f86abf89d6362bfa4b3dc763
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=80f5105dad377522f86abf89d6362bfa4b3dc763;hp=bff0c590e5e857d3ce06d454f260d4263e10cc05
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Sep 12 09:52:46 2021 +0100

    sshproxy: keep addr and free it on close.
    
    The caller of new_connection has relinquished ownership of the
    SockAddr it passes in. So the receiver of that SockAddr must remember
    to free it, or else we leak memory.
    
    (Additionally, this means SshProxy will be able to remember the
    address during its run, e.g. to use in calls to its Plug. But that's
    not implemented yet.)

 sshproxy.c | 5 +++++
 1 file changed, 5 insertions(+)

commit c06c9c730fbe4033b038e36cb14a8382dd8f32b5
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=c06c9c730fbe4033b038e36cb14a8382dd8f32b5;hp=80f5105dad377522f86abf89d6362bfa4b3dc763
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Sep 12 09:52:46 2021 +0100

    Fill in missing implementation of pty_sendbuffer.
    
    Going through all the backends' send() and sendbuffer() routines, I
    noticed that the Unix pty backend is the only one where the return
    value from send() doesn't match what sendbuffer() would tell you,
    apparently because sendbuffer() was a stub implementation that I never
    got round to filling in properly.
    
    But pty masters _can_ back up, and if they do, we should return the
    appropriate data.

 unix/pty.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

commit 82177956daeb425a0df25866c2345647bb6c5b28
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=82177956daeb425a0df25866c2345647bb6c5b28;hp=c06c9c730fbe4033b038e36cb14a8382dd8f32b5
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Sep 12 09:52:46 2021 +0100

    Divide seat_set_trust_status into query and update.
    
    This complicates the API in one sense (more separate functions), but
    in another sense, simplifies it (each function does something
    simpler). When I start putting one Seat in front of another during SSH
    proxying, the latter will be more important - in particular, it means
    you can find out _whether_ a seat can support changing trust status
    without having to actually attempt a destructive modification.

 pscp.c                   |  3 ++-
 psftp.c                  |  3 ++-
 putty.h                  | 22 ++++++++++++++++------
 ssh/connection1-client.c |  3 ++-
 ssh/connection2-client.c |  3 ++-
 ssh/server.c             |  1 +
 ssh/sesschan.c           |  1 +
 ssh/userauth2-client.c   |  3 ++-
 sshproxy.c               | 25 +++++++++++++++----------
 unix/console.c           | 15 ++++++++++++---
 unix/plink.c             |  1 +
 unix/window.c            | 10 ++++++++--
 utils/nullseat.c         |  5 +++--
 windows/console.c        | 15 ++++++++++++---
 windows/plink.c          |  1 +
 windows/window.c         | 10 ++++++++--
 16 files changed, 88 insertions(+), 33 deletions(-)

commit c3366435765afcfcef30cff8b65da4dcf36c2bd7
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=c3366435765afcfcef30cff8b65da4dcf36c2bd7;hp=82177956daeb425a0df25866c2345647bb6c5b28
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Sep 12 09:52:46 2021 +0100

    Separate backend_send from backend_sendbuffer.
    
    On a similar theme of separating the query operation from the
    attempted change, backend_send() now no longer has the side effect of
    returning the current size of the send buffer. Instead, you have to
    call backend_sendbuffer() every time you want to know that.

 otherbackends/raw.c      |  6 ++----
 otherbackends/rlogin.c   |  6 ++----
 otherbackends/supdup.c   |  5 ++---
 otherbackends/telnet.c   |  6 ++----
 otherbackends/testback.c | 21 ++++++++++++++-------
 pscp.c                   |  3 ++-
 putty.h                  |  9 ++++-----
 ssh/sesschan.c           |  3 ++-
 ssh/ssh.c                |  6 ++----
 sshproxy.c               |  3 ++-
 unix/pty.c               |  6 ++----
 unix/serial.c            |  6 ++----
 windows/conpty.c         |  5 ++---
 windows/plink.c          |  3 ++-
 windows/serial.c         |  5 ++---
 15 files changed, 44 insertions(+), 49 deletions(-)



More information about the tartarus-commits mailing list