simon-git: putty (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  10d3645a Remove an unused helper function.
  1b851758 Add some missing #includes.
  40dfbeba Fix aes-select.c macros again.
  a8981212 Add a missing prototype.
  ed94aa50 Remove spurious 'const' on return types.
  c12cde1b Fix an uninitialised variable.
  9a84a89c Add a batch of missing 'static's.
  26f220a1 Remove a completely unused global variable.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2022-09-03 12:06:46

commit 10d3645a9319bca828aacc89638a3af28a110d64
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=10d3645a9319bca828aacc89638a3af28a110d64;hp=23245fb4185171c1e687a8bc64f4e1f148e6e7ea
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Sep 3 11:39:15 2022 +0100

    Remove an unused helper function.
    
    I was wondering what this was doing here at all when strbuf_chomp is a
    better choice. The answer turned out to be 'nothing' - it wasn't even
    used any more.

 import.c | 11 -----------
 1 file changed, 11 deletions(-)

commit 1b851758bd02c03fa9ae1736bc2646ac46d81df0
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=1b851758bd02c03fa9ae1736bc2646ac46d81df0;hp=10d3645a9319bca828aacc89638a3af28a110d64
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Sep 3 11:43:46 2022 +0100

    Add some missing #includes.
    
    My experimental build with clang-cl at -Wall did show up a few things
    that are safe enough to fix right now. One was this list of missing
    includes, which was causing a lot of -Wmissing-prototype warnings, and
    is a real risk because it means the declarations in headers weren't
    being type-checked against the actual function definitions.
    
    Happily, no actual mismatches.

 cmake/gitcommit.cmake                  | 1 +
 keygen/mpunsafe.c                      | 1 +
 psocks.c                               | 1 +
 utils/x11_dehexify.c                   | 1 +
 utils/x11_identify_auth_proto.c        | 1 +
 utils/x11_parse_ip.c                   | 1 +
 windows/no-jump-list.c                 | 2 ++
 windows/plink.c                        | 1 +
 windows/utils/arm_arch_queries.c       | 1 +
 windows/utils/minefield.c              | 1 +
 windows/utils/platform_get_x_display.c | 1 +
 windows/window.c                       | 1 +
 12 files changed, 13 insertions(+)

commit 40dfbeba41926260fe3f419197e7050823565e64
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=40dfbeba41926260fe3f419197e7050823565e64;hp=1b851758bd02c03fa9ae1736bc2646ac46d81df0
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Sep 3 10:43:48 2022 +0100

    Fix aes-select.c macros again.
    
    I decided that the 'namemaker' system introduced recently in commit
    fbb979aa985cdcd was just too marginal to be sensible, and it's easier
    to simply quote the full SSH id for each protocol.
    
    Also, included an empty argument at the end of each macro invocation,
    so that the variadic "..." is never completely missing.

 crypto/aes-select.c | 31 +++++++++++++------------------
 1 file changed, 13 insertions(+), 18 deletions(-)

commit a8981212f513dadd4954173a4cb117d96c32e85c
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=a8981212f513dadd4954173a4cb117d96c32e85c;hp=40dfbeba41926260fe3f419197e7050823565e64
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Sep 3 10:54:10 2022 +0100

    Add a missing prototype.
    
    Too much C++, I expect - 'void foo()' in C++ means what I wanted it to
    mean!

 misc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit ed94aa5058c0c4c99723dbd86a14d67172df015a
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=ed94aa5058c0c4c99723dbd86a14d67172df015a;hp=a8981212f513dadd4954173a4cb117d96c32e85c
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Sep 3 10:54:42 2022 +0100

    Remove spurious 'const' on return types.

 ssh.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

commit c12cde1bea7a530d9771dccdaa907a65aa6a44ed
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=c12cde1bea7a530d9771dccdaa907a65aa6a44ed;hp=ed94aa5058c0c4c99723dbd86a14d67172df015a
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Sep 3 11:12:29 2022 +0100

    Fix an uninitialised variable.
    
    This looks like a real error! And recently introduced, in commit
    cd094b28a3b1779.

 windows/controls.c | 1 +
 1 file changed, 1 insertion(+)

commit 9a84a89c32e94918a7a98518cd2683473851dc9b
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=9a84a89c32e94918a7a98518cd2683473851dc9b;hp=c12cde1bea7a530d9771dccdaa907a65aa6a44ed
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Sep 3 12:02:48 2022 +0100

    Add a batch of missing 'static's.

 crypto/bcrypt.c        | 18 +++++++++---------
 crypto/ecc-ssh.c       |  6 +++---
 crypto/ntru.c          | 15 +++++++++------
 crypto/openssh-certs.c | 28 +++++++++++++++-------------
 crypto/rsa.c           |  3 ++-
 import.c               |  4 ++--
 proxy/cproxy.c         |  3 ++-
 proxy/proxy.c          |  2 +-
 ssh/sftp.c             |  2 +-
 ssh/sharing.c          | 17 ++++++++---------
 ssh/zlib.c             | 21 ++++++++++-----------
 terminal/bidi.c        |  7 ++++---
 terminal/terminal.c    |  2 +-
 utils/x11authfile.c    |  4 ++--
 windows/network.c      |  7 ++++---
 windows/unicode.c      |  2 +-
 16 files changed, 74 insertions(+), 67 deletions(-)

commit 26f220a1a0b095336af61af6c5bfac5d4f038ddc
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=26f220a1a0b095336af61af6c5bfac5d4f038ddc;hp=9a84a89c32e94918a7a98518cd2683473851dc9b
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Sep 3 12:02:58 2022 +0100

    Remove a completely unused global variable.

 windows/gss.c | 2 --
 1 file changed, 2 deletions(-)