simon-git: putty (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sun Sep 4 11:24:09 BST 2022


TL;DR:
  9e7d4c53 Rename confusing variables in psftp_main().

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2022-09-04 11:24:09

commit 9e7d4c53d80b6ebb9598610ab706faf2218c8a7b
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=9e7d4c53d80b6ebb9598610ab706faf2218c8a7b;hp=26f220a1a0b095336af61af6c5bfac5d4f038ddc
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Sep 4 10:54:34 2022 +0100

    Rename confusing variables in psftp_main().
    
    Another of this weekend's warnings pointed out that this function
    contained a pattern I now regard as a cardinal sin: variables called
    'ret' that aren't clear whether they've _been_ returned from a
    subroutine, or whether they're _planned_ to be returned from the
    containing function. Worse, psftp_main had both: two of the former
    kind shadowing a case of the latter in sub-scopes.

 psftp.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)



More information about the tartarus-commits mailing list